Initial Launch Branch (Do not merge)#21
Open
BenHarris4848 wants to merge 22 commits intolaunch_branchfrom
Open
Initial Launch Branch (Do not merge)#21BenHarris4848 wants to merge 22 commits intolaunch_branchfrom
BenHarris4848 wants to merge 22 commits intolaunch_branchfrom
Conversation
ckdesir
requested changes
Nov 17, 2022
| val slug: String, | ||
| val shoutouts: Double, | ||
| val websiteURL: String, | ||
| val contentTypes: List<String>, |
Member
There was a problem hiding this comment.
I think this would be better as a list of ENUMS than raw strings so it scales better from the source of truth;
should be
val contentTypes: List<ContentType>,
val websiteURL: String,
val numArticles: Double,
val mostRecentArticle: Article? = null,
val socials: List<Social>
)
enum class ContentType {
MAGAZINES, ARTICLES
}
Contributor
Author
There was a problem hiding this comment.
Implemented these changes on emily-content-type (so that they can eventually be merged into main), then incorporated those changes into this branch. This way we can have the enum change in main next semester, and keep the filtering only in this branch.
| rssURL = publication.rssURL, | ||
| slug = publication.slug, | ||
| shoutouts = publication.shoutouts, | ||
| contentTypes = publication.contentTypes, |
Member
There was a problem hiding this comment.
Instead of contentTypes = publication.contentTypes, we can create the enums from the content type itself:
contentTypes = publication.contentTypes.map {
ContentType.valueOf(it.uppercase())
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Prepare a branch to launch to the play store.
Changes Made
Test Coverage
Manual testing
Next Steps
Launch!